减少行数或使此代码更高效[关闭]

Posted 2023-02-23

【中文标题】减少行数或使此代码更高效[关闭]

【英文标题】：Reduce line count or make this code more efficient [closed]

【发布时间】：2017-03-29 01:17:45

【问题描述】：

在我不断增长的知识追求中，我想知道是否有任何方法可以减少行数或提高代码效率。它是我制作的一款游戏，我已经挑战自己让它尽可能短，（在原版中它大约是这个的两倍：D）

import random
gameLives,hints,wonGame,levels,awardedLives,levelRange=3,6,0,[1,2,3,4,5,6,7,8,9,10],[1,3,5,7,10,12,15,20,0,0],[5,10,20,50,100,200,250,300,400,500]
def is_valid(guess):
    try:
        guess=int(guess)
        return True,guess
    except:
        print("Try again, not a number")
        repeat=1
def GameLevel(Range,gameLives,level,hints):
    lives,hints,targetnumber,repeat=gameLives,hints,random.randint(1,1),1
    print("LEVEL \nThinking...".format(level))
    if level>1:
        print("You now have  lives remaining".format(gameLives))
    if level==10:
        print("Welcome to the hardest level\nNo bonus lives are awarded for the final level")
    print("This number is between 1 and "+str(Range))
    while repeat==1:
        guess=input("What is your guess? ")
        guess,repeat,targetnumber=guess.lower(),0,str(targetnumber)
        if guess=="hint":
            if level>=3:
                if hints!=1:
                    targetnumber=int(targetnumber)
                    print("Number is between  and ".format((targetnumber // 10) * 10, (targetnumber // 10 + 1) * 10))
                    repeat,hints=1,hints-1
                else:
                    print("Sorry you have ran out of hints :(")
                    repeat=1
            else:
                print("Hints are not available until level 3")
                repeat=1
        elif guess==targetnumber:
            print("Well done, You have guessed my number!")
            return lives,hints
        elif guess!=targetnumber:
            if is_valid(guess)==True:
                print("Sorry that is not my number, you have lost a life. :(")
                targetnumber,lives,repeat=int(targetnumber),lives-1,1
                if lives<=0:
                    print("You have lost all your lives, so this means I win\nThe program will now end")
                    input("")
                    exit()
                if guess<targetnumber:
                    print("The target number is higher")
                else:
                    print("The target number is lower")
            else:
                repeat=1
print("Welcome to my number guessing game!\nI will think of a number between a certain range and you have to guess it.\nEach time you guess my number I will think of a harder one.\nYou will start with  lives and  hints, Good Luck!\nTo use your hint you will have to enter the word hint\nExtra lives will be awarded for each completed level".format(gameLives,(hints-1)))
a,b=0,0
for level in levels:
    Range=levelRange[a]
    gameLives,hints=GameLevel(Range,gameLives,level,hints)
    if gameLives>0 and wonGame!=10:
        addLives=awardedLives[b]
        if addLives!=0:
            print("You have gained  extra lives".format(addLives))
            gameLives+=addLives
        wonGame+=1
    a,b=a+1,b+1
score=gameLives+10*(hints-1)
print("Calculating your score.\nYour score is  . Well done!".format(score))

【问题讨论】：

如果此操作没有错误，则属于 CR 或 Code Golf。

您可以将您的源代码提交到Code Review Stack。

如果你增加行数一点，你的程序读起来会更舒服。不要像那样把所有东西都塞在一起，添加一些空格！函数定义应该在它们的上方和下方有一个空行，运算符和等号应该有一个空格，等等。参见PEP-0008。也不要使用“裸”except：最好给出您想要捕获的实际异常名称（如ValueError）。

@J.Piquard 虽然Code Review 可能是提出这类问题的好地方，但我们应该改掉向那里发送问题的习惯。请阅读this 元帖子进行澄清。

@PM2Ring，我刚刚回答了代替TigerhawkT3来解码CR的意思。关于您建议的元帖子，由于问题请求 “使代码更高效” 和 “正常工作”，代码审查似乎已适应。

【参考方案1】：

这是我设法让程序仍然以相同方式运行的最小程序，在代码为 63 行的问题中，我设法将其减少到 29 行；

import random; gameLives,hints,wonGame,levels,awardedLives,levelRange=3,6,0,[1,2,3,4,5,6,7,8,9,10],[1,3,5,7,10,12,15,20,0,0],[5,10,20,50,100,200,250,300,400,500]
def is_valid(y):
    try:y=int(y);return True
    except:print("Try again, not a number")
def GameLevel(Range,gameLives,level,hints):
    lives,hints,targetnumber=gameLives,hints,random.randint(1,Range);print("LEVEL \nThinking...".format(level))
    if level>1:print("You now have  lives remaining".format(gameLives))
    if level==int(levels[-1]):print("Welcome to the hardest level\nNo bonus lives are awarded for the final level")
    print("This number is between 1 and "+str(Range))
    while True:
        guess=input("What is your guess? ");targetnumber=str(targetnumber)
        if guess.lower()=="hint":
            if level>=3:
                if hints!=1:targetnumber,hints=int(targetnumber),hints-1;print("Number is between  and ".format((targetnumber // 10) * 10, (targetnumber // 10 + 1) * 10))
                else:print("Sorry you have ran out of hints :(")
            else:print("Hints are not available until level 3")
        elif guess==targetnumber:print("Well done, You have guessed my number!");return lives,hints
        elif guess!=targetnumber and is_valid(guess)==True:
            print("Sorry that is not my number, you have lost a life. :(");guess,targetnumber,lives=int(guess),int(targetnumber),lives-1
            if lives<=0:exit(input("You have lost all your lives, so this means I win\nThe program will now end\n"))
            print("The target number is ".format("higher" if (guess<targetnumber) else "lower"))
print("Welcome to my number guessing game!\nI will think of a number between a certain range and you have to guess it.\nEach time you guess my number I will think of a harder one.\nYou will start with  lives and  hints, Good Luck!\nTo use your hint you will have to enter the word hint\nExtra lives will be awarded for each completed level".format(gameLives,(hints-1)));a,b=0,0
for level in levels:
    gameLives,hints=GameLevel((levelRange[a]),gameLives,level,hints)
    if gameLives>0 and wonGame!=int(levels[-1]):
        if awardedLives[b]>0:print("You have gained  extra lives".format(awardedLives[b]));gameLives+=awardedLives[b]
        wonGame+=1
    a,b=a+1,b+1
input("Calculating your score.\nYour score is  . Well done!".format(gameLives+10*(hints-1)))