一些通过SAP ABAP代码审查得出的ABAP编程最佳实践

Posted 2021-02-07 sap-jerry

1. 这两个IF ELSE分支里检测的条件其实逻辑上来说都是同一类，应该合并到一个IF分支里进行检查：

It is an expensive operation to open a file in application server with 50MB file size.

Current logic is:

1. Open the file in application server

2. Read the file content line by line

3. If the file is regarding IPG or MIDH or TPG, handle with each line separately

The correct logic should be:

1. Check the file path whether it is IPG or MIDH or TPG related. If not, quit the report.

2. Handle with each line directly without evaluate file path in the BIG loop.

The validation logic for input records should be improved

Loop at all service BOM, check whether the ID in current loop does exist in validation table lt_valid_prod or lt_valid_sp. If so, delete them via DELETE TABLE XXX FROM

Improvement: use DELETE XXX WHERE product_id NOT IN

这是一个性能问题。使用ABAP原生支持的NOT IN关键字可以获得更好的性能。性能评测如下：

Avoid using SELECT to access table with a large number of entries

In product / IObject area, the best practice is to use OPEN CURSOR / FETCH NEXT CURSOR to access big DB table.

如果需要用ABAP OPEN SQL读取一张包含海量记录的数据库表，那么推荐使用OPEN CURSOR进行分块读取。

Although this solution will spend almost the same time to fetch the data from DB, it has far less memory consumption compared with using SELECT to fetch ALL data from DB at one time.

The original dump due to out of memory issue could be eliminated by replace SELECT with OPEN CURSOR statement.

这种方式和直接用SELECT相比，能显著减少内存消耗量。

使用并发编程提高应用程序场景

通过下面这段代码模拟一个费时的ABAP程序：

定义一个ABAP函数：

这个函数里执行一大堆计算，然后把传入的product ID写到一张自定义表ZJERRY1里。

调用这个函数的代码：

注意第二种方案使用STARTING NEW TASK达到的并发执行效果：

通过比较，第二种解决方案的效率是第一种的四倍。

1. The more CPU & DB time spent in ZINSERT, the better performance will be gained by using

parallel processing (Asynchronous RFC call).

2. The more number of ZINSERT call, the better performance will be gained by using parallel

processing.

要获取更多Jerry的原创文章，请关注公众号"汪子熙":